Fortran REAL16: improve detection and wiring across OMPI/OPAL #13612
+537
−354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
force-pushed
the
topic/better_support_for_fortran_real16
branch
from
9d83217 to
846dfb9
Compare
devreal
reviewed
Jan 6, 2026
Contributor
devreal
left a comment
devreal
left a comment
There was a problem hiding this comment.
Minor nit-pick. Can we document in the code why we pick the order the way it is?
bosilca
force-pushed
the
topic/better_support_for_fortran_real16
branch
2 times, most recently
from
0148404 to
58cd5a4
Compare
Member
Author
Which order ? During configure or in the header files ? |
Member
|
@bosilca Getting an mpi4py floating point exception in CI. Can you investigate? |
Member
|
this doesn't fix the issue reported in issue #13564 |
bosilca
force-pushed
the
topic/better_support_for_fortran_real16
branch
from
58cd5a4 to
a58d6a0
Compare
Check first for _Float128 then __float128 and then for _Quad type (Intel compiler) and pick the one that matches the Fortran REAL16 type. This commit adds support for pack, unpack as well as MPI_Op. As of today, no hardware support (AVX* or SVE) exists for the 128 bits floating point, so the only valid MPI_Op for this type is the base op (provided in software by most recent compilers). Signed-off-by: George Bosilca <gbosilca@nvidia.com>
bosilca
force-pushed
the
topic/better_support_for_fortran_real16
branch
from
a58d6a0 to
151fd6d
Compare
bosilca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probe REAL*16 against _Float128 first, then __float128, and finally _Quad (Intel) to find a C type with matching bit representation. Ensure OPAL’s FLOAT12/FLOAT16 constructors are always available and map OMPI/MPI REAL16 based on architecture/language specifics.
Wire FLOAT128 types through copy/pack/unpack paths and hook REAL16 into the base MPI_Op table. This enables software-only reductions for REAL16 for as long as the Fortran type has a C equivalent.
Fixes #13564